HIVE-29345: Support Alter table command for write ordering. #6256
+573
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kokila-19
force-pushed
the
alter_natural_order
branch
from
22a148b to
9d5ffb3
Compare
asf-ci-hive
added
tests pending
tests passed
and removed
tests unstable
tests pending
labels
deniskuzZ
reviewed
Jan 5, 2026
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/BaseHiveIcebergMetaHook.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Jan 5, 2026
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/BaseHiveIcebergMetaHook.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Jan 5, 2026
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Jan 5, 2026
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/BaseHiveIcebergMetaHook.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Jan 5, 2026
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Jan 5, 2026
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/BaseHiveIcebergMetaHook.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Jan 5, 2026
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Jan 5, 2026
.../java/org/apache/hadoop/hive/ql/ddl/table/storage/order/AlterTableSetWriteOrderAnalyzer.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Jan 5, 2026
.../java/org/apache/hadoop/hive/ql/ddl/table/storage/order/AlterTableSetWriteOrderAnalyzer.java
Outdated
Show resolved
Hide resolved
kokila-19
force-pushed
the
alter_natural_order
branch
from
9d5ffb3 to
f35e6f3
Compare
asf-ci-hive
added
tests pending
tests failed
and removed
tests passed
tests pending
labels
kokila-19
force-pushed
the
alter_natural_order
branch
from
f35e6f3 to
c020934
Compare
asf-ci-hive
added
tests pending
tests passed
and removed
tests failed
tests pending
labels
Contributor
Author
|
I have addressed all the comments and refactored the code as well. |
deniskuzZ
reviewed
Jan 14, 2026
.../java/org/apache/hadoop/hive/ql/ddl/table/storage/order/AlterTableSetWriteOrderAnalyzer.java
Show resolved
Hide resolved
deniskuzZ
reviewed
Jan 14, 2026
.../java/org/apache/hadoop/hive/ql/ddl/table/storage/order/AlterTableSetWriteOrderAnalyzer.java
Outdated
Show resolved
Hide resolved
kokila-19
force-pushed
the
alter_natural_order
branch
from
c020934 to
1acba18
Compare
asf-ci-hive
added
tests pending
tests passed
and removed
tests passed
tests pending
labels
kokila-19
force-pushed
the
alter_natural_order
branch
from
1acba18 to
a7450f2
Compare
asf-ci-hive
added
tests pending
tests failed
and removed
tests passed
tests pending
labels
SYNTAX: ALTER TABLE table_name SET WRITE ORDERED BY column_name sort_direction NULLS FIRST/LAST, ... EXAMPLE: ALTER TABLE table_order SET WRITE ORDERED BY id desc nulls first, name asc nulls last;
kokila-19
force-pushed
the
alter_natural_order
branch
from
a7450f2 to
d6f7881
Compare
asf-ci-hive
added
tests pending
tests passed
tests unstable
and removed
tests failed
tests pending
tests passed
tests unstable
labels
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Implemented Natural ordering(write ordered by) ALTER TABLE DDL support for Iceberg tables.
Why are the changes needed?
Existing tables can be converted to natural ordered tables using ALTER command. Note that only the data inserted after alter query are ordered, not existing data.
Does this PR introduce any user-facing change?
yes, supported new syntax
SYNTAX:
ALTER TABLE table_name SET WRITE ORDERED BY column_name sort_direction NULLS FIRST/LAST, ...
EXAMPLE:
ALTER TABLE table_order SET WRITE ORDERED BY id desc nulls first, name asc nulls last;
How was this patch tested?
qtest